Conversation
Since ```self._dispatch``` has ```dict.__repr__: self._pprint_dict``` the ```elif``` block is not needed.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
aeros
left a comment
There was a problem hiding this comment.
Thanks for the PR @Palakjha and welcome!
This PR will require a signed CLA prior to merging, since it involves a code change (even if it's just removing 6 lines). After 24-48 hours of signing the CLA, you can check the status via the CLA assistant. If it detects that your CLA has been signed, the label will update from CLA not signed to CLA signed.
Let me know if you have any questions. :)
|
This change makes a difference in semantics (perhaps a good one) in this case: Before the change MyDict.repr is ignored and the dict contents are printed. After the change it prints "I do my own thing" 50 times. |
iritkatriel
left a comment
There was a problem hiding this comment.
Since this causes a change in behavior it needs to be submitted with an appropriate title/commit message, test and documentation update.
|
Since the original author has vanished, I'm going to close this and note that I did so on the bpo. |
Since
self._dispatchhasdict.__repr__: self._pprint_dicttheelifblock is not needed.https://bugs.python.org/issue39994